Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend improvements for match rescheduling #530

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

robigan
Copy link
Contributor

@robigan robigan commented Feb 25, 2024

PR to support custom schedules instead of the automatic ones.

Discussed in #519

Copy link

vercel bot commented Feb 25, 2024

Someone is attempting to deploy a commit to a Personal Account owned by @evroon on Vercel.

@evroon first needs to authorize it.

@robigan
Copy link
Contributor Author

robigan commented Feb 25, 2024

I have just realized, there already is a match component. With the custom duration built in.
Mfw
Bruh

@robigan robigan force-pushed the frontend-manual-rescheduling branch from f48aee3 to b39821b Compare March 6, 2024 12:41
Copy link
Contributor

github-actions bot commented May 5, 2024

This PR is stale because it has been open for 45 days with no activity. Remove the stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label May 5, 2024
@github-actions github-actions bot removed the Stale label Jun 3, 2024
Copy link
Contributor

github-actions bot commented Jul 4, 2024

This PR is stale because it has been open for 45 days with no activity. Remove the stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label Jul 4, 2024
@robigan robigan marked this pull request as ready for review July 10, 2024 12:58
@robigan
Copy link
Contributor Author

robigan commented Jul 10, 2024

Actually I should so some testing but I gtg

@robigan
Copy link
Contributor Author

robigan commented Jul 10, 2024

@evroon We have our UI setup like this, but I saw that you made a change where onClick of the schedule row's card it opens the update model. I feel like the whole tap a card thing to open is more of a mobile thing, and on desktop isn't clear that it can be clicked, plus the drag mouse UI doesn't help either to indicate it is clickable. You introduced the change in 24f04fb

image

@evroon
Copy link
Owner

evroon commented Jul 11, 2024

@evroon We have our UI setup like this, but I saw that you made a change where onClick of the schedule row's card it opens the update model. I feel like the whole tap a card thing to open is more of a mobile thing, and on desktop isn't clear that it can be clicked, plus the drag mouse UI doesn't help either to indicate it is clickable. You introduced the change in 24f04fb

image

Hmm how would you improve it? Have some kind of button like the green pencil one in your screenshot that opens the modal?

@github-actions github-actions bot removed the Stale label Jul 12, 2024
@evroon
Copy link
Owner

evroon commented Jul 13, 2024

I'm not sure I understand what this PR does. What problem does this PR solve exactly? I guess what it does is allow you to enter a datetime instead of margins/durations, but what is the use case it targets?

@robigan
Copy link
Contributor Author

robigan commented Jul 13, 2024

@evroon We have our UI setup like this, but I saw that you made a change where onClick of the schedule row's card it opens the update model. I feel like the whole tap a card thing to open is more of a mobile thing, and on desktop isn't clear that it can be clicked, plus the drag mouse UI doesn't help either to indicate it is clickable. You introduced the change in 24f04fb
image

Hmm how would you improve it? Have some kind of button like the green pencil one in your screenshot that opens the modal?

Yup, we had this same UI problem with the old schedule page, I see you've removed. It just wasn't clear to our tournament staff they had to click to edit the match

@robigan
Copy link
Contributor Author

robigan commented Jul 13, 2024

I'm not sure I understand what this PR does. What problem does this PR solve exactly? I guess what it does is allow you to enter a datetime instead of margins/durations, but what is the use case it targets?

Originally, there was no proper way to edit the custom duration/delay fields of matches, nor was it intuitive, and our staff thought that they had to do it from the planning page. And aimed to add that functionality, this PR now basically adds some QoL features such as having functionality to calculate the delay required if you want the next match to start at a certain time, and adding that button to hint to the user they can actually edit the card. In terms of DX, I also added some typings pertaining the parts of code I touched but I could add more typings

@robigan
Copy link
Contributor Author

robigan commented Jul 13, 2024

Oh, and cleaned up some typings and added some code optimizations.

@robigan
Copy link
Contributor Author

robigan commented Jul 13, 2024

Gotta still test some things, this isn't exactly merge ready

@robigan
Copy link
Contributor Author

robigan commented Jul 13, 2024

Actually yeah the rest of the type system is complaining, I might might just type everything

@robigan robigan force-pushed the frontend-manual-rescheduling branch from 4931e52 to b59676b Compare July 15, 2024 13:07
@robigan robigan changed the title Frontend manual rescheduling Frontend improvements for match rescheduling Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants